-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question(flaky): cortex -v
hangs when checking if there is a newer release?
#1268
Comments
cortex -v
hang when checking if new release is avail?cortex -v
hangs when checking if there is a newer release?
We check the new nightly version with |
Timeout to 1 s is a good workaround! Q: I'm just wondering whether we need to check versions at the end of every command? Rationale
Dumb Ideas
cortex
cortex -v
cortex start # Server start is an impt entrypoint to using cortex, and will call attention.
cortex run # Starting an interactive chat shell is another impt entrypoint to using cortex
#Optionally
COMMAND -h # Not annoying to put it in all the help commands as well I'm not sure what the best fix is, but I do think shortening timeout to 1sec is a (good) but temporary patch to this issue. cc @dan-homebrew |
I would like to propose 2 approaches that can help to handle update check better:
cc @dan-homebrew |
Sure, open to the above.
cc @dan-homebrew db-less design holds us back on certain things like this My only request is that, UX wise, the following should inform users there is an available update: cortex (-h)
cortex -v |
Will add update info into
Interval to check update:
|
Nice. Is this a cron job that we're always running on the users machine? |
It only runs when the next CLI command is executed. |
Closing as resolved. QA'd adn works really well 🙏 |
Flakey issue. Happens 1/3 times.
Steps:
cortex -v
or any command reallyWhat causes this?
Where's our endpoint for checking if there's a more recent version, and is this endpoint prone to lagging?
The text was updated successfully, but these errors were encountered: