Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Recommended" labels don't autoupdate when user toggles CPU and GPU modes #1142

Closed
Tracked by #1108 ...
rh45-one opened this issue Apr 15, 2024 · 9 comments
Closed
Tracked by #1108 ...
Assignees
Labels
category: hardware management Related to hardware & compute type: bug Something isn't working

Comments

@rh45-one
Copy link

rh45-one commented Apr 15, 2024

Bug Description
By default Jan will choose CPU mode. My local AI models are marked as "Recommended".
When enabling Experimental Mode and Vulkan support, all local models are marked as "Slow on your device" (probably due to my GPU's 4GB of VRAM).
After disabling Vulkan support and Experimental Mode (returning to the default settings), all local models will still appear as "Slow on your device" and will fail to start.

Steps to reproduce
Local models appear as "Recommended"

  1. Open Jan Settings
  2. Open the Advanced Settings tab
  3. Enable Experimental Mode and Vulkan Support

Local models will now appear as "Slow on your device"

  1. Disable Experimental Mode and Vulkan Support

Local models will still be marked as "Slow on your device" despite having returned to the default settings.

Expected behavior
After disabling Experimental and Vulkan settings, all local models will return to the previous state and appear as "Recommended" (if they ever did in the first place).

Environment details

  • Operating System: Windows 11 23H2
  • Jan Version: v0.4.10
  • Processor: AMD Ryzen 5 3600
  • RAM: 32GB
  • GPU: RX570 4GB

Solution
Settings > Advanced Settings > Reset to Factory Default
Then, you can import your models again and they will run using the default CPU mode (just like it did at the start, before changing any Experimental or Vulkan settings), and they will be marked as "Recommended".

@rh45-one rh45-one added the type: bug Something isn't working label Apr 15, 2024
@rh45-one rh45-one changed the title bug: [DESCRIPTION] bug: CPU and GPU support toggle - "Slow on your device" Apr 15, 2024
@rh45-one rh45-one changed the title bug: CPU and GPU support toggle - "Slow on your device" bug: CPU and GPU modes - "Slow on your device" Apr 15, 2024
@Van-QA
Copy link
Contributor

Van-QA commented Apr 16, 2024

Assigning this to @hiento09 since we are still investigating how to display the Memory value when using Vulkan support 🙏

@Van-QA
Copy link
Contributor

Van-QA commented May 28, 2024

Adding the script from contributor for future reference: https://discord.com/channels/1107178041848909847/1213048058955300934/1243533268620541954

@imtuyethan
Copy link
Contributor

Should be solved once we complete #1108

@imtuyethan imtuyethan added the duplicate This issue or pull request already exists label Aug 30, 2024
@imtuyethan
Copy link
Contributor

I'll mark this as duplicate & should be a user story of the #1108 epic

@imtuyethan imtuyethan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@imtuyethan imtuyethan closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
@imtuyethan imtuyethan reopened this Aug 30, 2024
@freelerobot freelerobot changed the title bug: CPU and GPU modes - "Slow on your device" bug: "Recommended" labels don't autoupdate when user toggles CPU and GPU modes Sep 5, 2024
@freelerobot freelerobot transferred this issue from janhq/jan Sep 6, 2024
@freelerobot freelerobot added the category: hardware management Related to hardware & compute label Sep 6, 2024
@dan-menlo
Copy link
Contributor

Handling this bug as part of #1165

@louis-jan
Copy link
Contributor

This is an app bug where it does not reset other settings when the experimental feature is toggled off.

Scenarios:

  1. Users toggle ON the Experimental Settings & Vulkan Support
  2. Users toggle OFF the Experimental Settings. The app should toggle off others automatically.

Bug fix:
It should toggle off features gated by Experimental Settings when toggling off.

Regarding the issue where app could not get Vulkan device VRAM which is not scoped by the issue, it should be a part of #1165

all local models will still appear as "Slow on your device"

@dan-menlo
Copy link
Contributor

dan-menlo commented Sep 26, 2024

This is an app bug where it does not reset other settings when the experimental feature is toggled off.

Scenarios:

  1. Users toggle ON the Experimental Settings & Vulkan Support
  2. Users toggle OFF the Experimental Settings. The app should toggle off others automatically.

Bug fix: It should toggle off features gated by Experimental Settings when toggling off.

Regarding the issue where app could not get Vulkan device VRAM which is not scoped by the issue, it should be a part of #1165

all local models will still appear as "Slow on your device"

@louis-jan I think we should handle this as part of a larger sprint on Hardware Detection, "llama.cpp version switching":

@gabrielle-ong
Copy link
Contributor

This is a combination of 2 issues

  • bug: app bug where it does not reset other settings when the experimental feature is toggled off (Louis' reply 2 message above)
  • feature request/epic: Support Vulkan devices

@louis-jan can I check if the app bug is pending or resolved? (and tag which issue)

I propose we use this issue for the app bug.
Then separately track the Vulkan support feature request under #1165 and #1218

@gabrielle-ong gabrielle-ong moved this from Review + QA to Investigating in Menlo Oct 16, 2024
@gabrielle-ong gabrielle-ong removed the duplicate This issue or pull request already exists label Oct 17, 2024
@dan-menlo
Copy link
Contributor

This should be handled by #1108. Closing for now

@github-project-automation github-project-automation bot moved this from Investigating to Review + QA in Menlo Oct 31, 2024
@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Nov 5, 2024
@gabrielle-ong gabrielle-ong modified the milestones: v1.0.2, v1.0.3 Nov 6, 2024
@gabrielle-ong gabrielle-ong removed this from the v1.0.3 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: hardware management Related to hardware & compute type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

10 participants