Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cortex API supports /embeddings #1102

Closed
freelerobot opened this issue Sep 5, 2024 · 5 comments · Fixed by janhq/cortex.llamacpp#283 or #1654
Closed

feat: Cortex API supports /embeddings #1102

freelerobot opened this issue Sep 5, 2024 · 5 comments · Fixed by janhq/cortex.llamacpp#283 or #1654
Assignees
Labels
Milestone

Comments

@freelerobot
Copy link
Contributor

Related issues:

@freelerobot freelerobot added the type: feature request A new feature label Sep 5, 2024
@dan-menlo dan-menlo changed the title feat: embeddings support feat: Cortex support embeddings Sep 8, 2024
@dan-menlo
Copy link
Contributor

@vansangpfiev @namchuai Can I check if we currently support this in cortex.cpp? (I recall the JS version did it already)

@dan-menlo dan-menlo moved this to Scheduled in Menlo Sep 8, 2024
@vansangpfiev
Copy link
Contributor

@vansangpfiev @namchuai Can I check if we currently support this in cortex.cpp? (I recall the JS version did it already)

No - we don't support it yet.

@freelerobot freelerobot changed the title feat: Cortex support embeddings feat: cortex embeddings functionality Sep 23, 2024
@dan-menlo dan-menlo moved this from Scheduled to Investigating in Menlo Oct 31, 2024
@dan-menlo
Copy link
Contributor

@nguyenhoangthuan99 I am reassigning this to you, as it is fairly similar to /chat/completions. Having Cortex support embeddings will allow us to integrate things like Page Assist Browser extension

@dan-menlo dan-menlo changed the title feat: cortex embeddings functionality feat: Cortex API supports /embeddings Oct 31, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this from Investigating to In Progress in Menlo Nov 5, 2024
@nguyenhoangthuan99 nguyenhoangthuan99 moved this from In Progress to In Review in Menlo Nov 8, 2024
@github-project-automation github-project-automation bot moved this from In Review to Review + QA in Menlo Nov 8, 2024
@nguyenhoangthuan99
Copy link
Contributor

We need to update documentations for API references and capabilities

@gabrielle-ong
Copy link
Contributor

gabrielle-ong commented Nov 12, 2024

Thank you @nguyenhoangthuan99! Nicely done. QAed on cortex.llamacpp v0.1.38
✅ QA: /embeddings endpoint

encoding:

  • float (default),
  • base64
    Image
    Image

Inputs:

  1. String (above)
  2. array of strings
  3. array of integers
  4. array of arrays

Image
Image
Image

Docs:
Image

@gabrielle-ong gabrielle-ong moved this from Review + QA to Completed in Menlo Nov 12, 2024
@gabrielle-ong gabrielle-ong modified the milestones: v1.0.3, v1.0.4 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants