Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JLedSequence.Stop() not working #115

Closed
arkypita opened this issue Jun 28, 2023 · 1 comment · Fixed by #116
Closed

JLedSequence.Stop() not working #115

arkypita opened this issue Jun 28, 2023 · 1 comment · Fixed by #116
Labels
bug

Comments

@arkypita
Copy link

I see an issue in JLedSequence.Stop()
It stops, but after calling .Update() few times, sequence start again.

I think a is_running_ = false; is missing in function .Stop()
I suggest to add this line.
@jandelgado jandelgado mentioned this issue Jun 29, 2023
Merged
@jandelgado
Copy link
Owner

Indeed that was missing. Thanks for the report. Fixed with 4.12.2

@jandelgado jandelgado added the bug label Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure JLedSequence stays stopped jandelgado/jled
2 participants
@arkypita @jandelgado