Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rotated terminal panic/behaviour #197

Merged
merged 4 commits into from
Sep 28, 2023
Merged

Fix rotated terminal panic/behaviour #197

merged 4 commits into from
Sep 28, 2023

Conversation

jamwaffles
Copy link
Collaborator

Closes #196

@jamwaffles jamwaffles mentioned this pull request Sep 28, 2023
Closed
@jamwaffles
Copy link
Collaborator Author

Tested on 128x64 display with Rotation270 and it works nicely for me.

@jamwaffles jamwaffles merged commit b266506 into master Sep 28, 2023
@jamwaffles jamwaffles deleted the fix-rotated-terminal branch September 28, 2023 15:39
@plm
Copy link

plm commented Sep 29, 2023

Thank you for the quick fix @jamwaffles! I can confirm the fix works in the fixed branch of my reproducer.

@jamwaffles
Copy link
Collaborator Author

Great! Thanks for testing! This is released in 0.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using terminal mode with 90/270 degree rotation leads to incorrect output and panic
2 participants
@jamwaffles @plm