Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump e-g core #181

Merged
merged 3 commits into from
May 18, 2023
Merged

Bump e-g core #181

merged 3 commits into from
May 18, 2023

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented May 14, 2023

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Update embedded-graphics and modernize examples.

@bugadani bugadani force-pushed the eg branch 2 times, most recently from ca99455 to 9b32b2e Compare May 14, 2023 15:14
@bugadani bugadani marked this pull request as ready for review May 14, 2023 15:15
@bugadani

This comment was marked as outdated.

@bugadani bugadani mentioned this pull request May 16, 2023
@bugadani bugadani marked this pull request as draft May 16, 2023 19:10
@bugadani bugadani marked this pull request as ready for review May 17, 2023 16:39
@jscatena88
Copy link

This looks good to me. I just pulled my hair out for a half hour trying to figure out why certain traits weren't implemented but it turns out I had just added the newest embedded_graphics in my cargo.toml not the older one

Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this!

@jamwaffles jamwaffles merged commit 7271f39 into rust-embedded-community:master May 18, 2023
@bugadani bugadani deleted the eg branch May 18, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants