-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of display size #139
Clarify usage of display size #139
Conversation
Would it be a better idea to remove the default |
Ah, I just saw #140. Let's go with that approach. |
Yes but only if you're fine with breaking changes :) |
Yep! That's fine. I need to get e-g 0.7 into this driver at some point too, so that's already breaking. |
38542a6
to
8df4287
Compare
@jamwaffles sorry for the noise, CI told me I'm a dummy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long to get to this. It all looks good to me!
Hi! Thank you for helping out with SSD1306 development! Please:
master
if you're not already up to dateCHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmt
on the project withcargo fmt --all
- CI will not pass without this stepPR description
Place some comments that (hopefully) help with the confusion around using different display sizes.
Closes #140