Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify usage of display size #139

Merged
merged 3 commits into from
Dec 14, 2020

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 3, 2020

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

Place some comments that (hopefully) help with the confusion around using different display sizes.

Closes #140

@jamwaffles
Copy link
Collaborator

Would it be a better idea to remove the default DSIZE = DisplaySize128x64 from GraphicsMode, TerminalMode, etc?

@jamwaffles
Copy link
Collaborator

Ah, I just saw #140. Let's go with that approach.

@bugadani
Copy link
Contributor Author

bugadani commented Dec 1, 2020

Yes but only if you're fine with breaking changes :)

@jamwaffles
Copy link
Collaborator

Yep! That's fine. I need to get e-g 0.7 into this driver at some point too, so that's already breaking.

@bugadani bugadani force-pushed the docs-improv branch 4 times, most recently from 38542a6 to 8df4287 Compare December 1, 2020 17:44
@bugadani
Copy link
Contributor Author

bugadani commented Dec 1, 2020

@jamwaffles sorry for the noise, CI told me I'm a dummy.

Copy link
Collaborator

@jamwaffles jamwaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to get to this. It all looks good to me!

@jamwaffles jamwaffles merged commit c27cf56 into rust-embedded-community:master Dec 14, 2020
@bugadani bugadani deleted the docs-improv branch December 14, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove type parameter defaults related to display size.
2 participants