-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add raw random noise example #108
Conversation
@therealprof This raises the question of moving some common stuff in the crate like initialisation routines into a trait so that all modes (including |
@jamwaffles Yes, I'm very up for that. Also we might want to reconsider the use of traits and maybe move to a simple enum instead for better code optimisation. |
extern crate cortex_m; | ||
extern crate cortex_m_rt as rt; | ||
extern crate panic_semihosting; | ||
extern crate stm32f1xx_hal as hal; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could slowly move to edition 2018 code. 😅
I also don't quite see the point of using semihosting in examples like this which only adds another stumbling block without any benefits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I want to upgrade all the examples in one big PR. Those imports are bugging me.
I also don't quite see the point of using semihosting in examples like this
What would be a better panic_*
to use in your opinion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
panic_halt or panic_abort.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than those nits which we can also address separately, this looks good to me.
Hm, I thought you re-enabled the regular merge feature? I can only squash and merge. |
Hasn't that always been the case? At any rate, that's what I'd prefer to do anyway. |
Rewriting the commits and autosquashing it means you're causing problems for people with work-in-progress stuff. I was hoping that the setting I recently recommended would only prevent merges of PRs with merges in them which is the bad stuff, but it seems it disables all merge commits. |
Hi! Thank you for helping out with SSD1306 development! Please:
master
if you're not already up to dateCHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmt
on the project withcargo fmt --all
- CI will not pass without this stepPR description
This is the result of an email discussion with @nebelgrau77 who is asking for assistance sending raw bytes to the display, without using
GraphicsMode
, etc. The example emulates an old TV with a white noise effect using random crap from therand
crate in no-std mode.