-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug_and_release to use separate build dirs #3299
Conversation
Thanks. This is very nice. Builds on Debian. The old files in the root of a build don't get removed with a make clean, but that's not too bad. |
Can always switch back to |
Approving and tagging needs documentation |
What about What about |
Also, as |
Good catch. I've checked the build trees I saved from the CI (see my commit b047958 to see how I did so in my branch debug-and-release-test), and added a few build directories to
I can't test that, but we don't generate the actions for It may be that it empties the build directories but doesn't remove them. Or maybe it does; I'm not sure. |
Just read through it, and can't see anything that needs to change as a result of this PR. Could possibly add a brief note about I'm not sure what debugging features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MacOS changes make me wonder why we do what's done but if it's needed and works, I suppose it's okay.
#3322 raised for documentation. |
Short description of changes
Adds the
debug_and_release
option to theCONFIG
inJamulus.pro
. This tellsqmake
to generate separate Makefiles for Debug and Release, each using a separate sub-directory (debug/
andrelease/
respectively) for build-generated files such as*.o
and others, instead of building them in the project root.The user can then invoke
make
ormake release
(the default) to build a release version, ormake debug
(explicitly) to build a debug version.This
debug_and_release
option was already the default for Windows builds, but not for other architectures.It was necessary also to change
mac/deploy_mac.sh
to search inMakefile.Release
instead ofMakefile
when looking for the value ofQMAKE_TARGET
.CHANGELOG: Build: Place build files in separate directories instead of project root.
Context: Fixes an issue?
Fixes #3092
Does this change need documentation? What needs to be documented and how?
Maybe in compilation instructions, if there are any parts that would need to change as a result. Maybe not.
Status of this Pull Request
Ready to test
What is missing until this pull request can be merged?
Review and test
Checklist