Remove testrepository dependency #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used to be important that requests-mock didn't break compatibility with nova or keystoneclient. This hasn't been a thing for a long time and those tests don't work any more. Scrap these old tests and ensure the requests-tip one is still actually working.
testrepository was an openstack concept necessary when you had a lot more tests than we do. It appears to be abandoned. Remove the dependency and go back to testtools.run for a launcher.
renovate bot
referenced
this pull request
in allenporter/pyrainbird
Jun 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests-mock](https://requests-mock.readthedocs.io/) ([source](https://togithub.com/jamielennox/requests-mock)) | `==1.10.0` -> `==1.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>jamielennox/requests-mock</summary> ### [`v1.11.0`](https://togithub.com/jamielennox/requests-mock/releases/tag/1.11.0) [Compare Source](https://togithub.com/jamielennox/requests-mock/compare/1.10.0...1.11.0) #### What's Changed - Upgrade GitHub Actions by [@​cclauss](https://togithub.com/cclauss) in [https://github.com/jamielennox/requests-mock/pull/224](https://togithub.com/jamielennox/requests-mock/pull/224) - Typing analysis and public type aliases by [@​noirbizarre](https://togithub.com/noirbizarre) in [https://github.com/jamielennox/requests-mock/pull/226](https://togithub.com/jamielennox/requests-mock/pull/226) - Use unittest.mock when available on Python > 3.3 by [@​jelly](https://togithub.com/jelly) in [https://github.com/jamielennox/requests-mock/pull/230](https://togithub.com/jamielennox/requests-mock/pull/230) - Tell urllib3 to ignore content length mismatch by [@​jamielennox](https://togithub.com/jamielennox) in [https://github.com/jamielennox/requests-mock/pull/232](https://togithub.com/jamielennox/requests-mock/pull/232) - Remove testrepository dependency by [@​jamielennox](https://togithub.com/jamielennox) in [https://github.com/jamielennox/requests-mock/pull/229](https://togithub.com/jamielennox/requests-mock/pull/229) #### New Contributors - [@​cclauss](https://togithub.com/cclauss) made their first contribution in [https://github.com/jamielennox/requests-mock/pull/224](https://togithub.com/jamielennox/requests-mock/pull/224) - [@​noirbizarre](https://togithub.com/noirbizarre) made their first contribution in [https://github.com/jamielennox/requests-mock/pull/226](https://togithub.com/jamielennox/requests-mock/pull/226) - [@​jelly](https://togithub.com/jelly) made their first contribution in [https://github.com/jamielennox/requests-mock/pull/230](https://togithub.com/jamielennox/requests-mock/pull/230) **Full Changelog**: jamielennox/requests-mock@1.10.0...1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/allenporter/pyrainbird). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMTAuMCIsInVwZGF0ZWRJblZlciI6IjM1LjExMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
This was referenced Jul 2, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testrepository was a speed up required when you had lots of tests running simultaneously. It was copied from openstack, but it appears to be abandoned these days. If not it's still a dependency we shouldn't need so remove it.