From 61d51987b13bdfd5a3437c86ed28f57f8f55af69 Mon Sep 17 00:00:00 2001 From: jamessynge Date: Sat, 23 Dec 2017 10:38:02 -0500 Subject: [PATCH] Remove obsolete comment from observatory.py. Add TODO about non-bisque mounts, which assumes all are serial. --- pocs/observatory.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/pocs/observatory.py b/pocs/observatory.py index b5974b0f0..0983ab4c8 100644 --- a/pocs/observatory.py +++ b/pocs/observatory.py @@ -495,12 +495,6 @@ def _create_mount(self, mount_info=None): This method ensures that the proper mount type is loaded. - Note: - This does not actually make a serial connection to the mount. To do so, - call the 'mount.connect()' explicitly. - TODO(jamessynge): Discuss this claim with Wilfred. SerialData automatically - opens the connection, but doesn't start using it. - Args: mount_info (dict): Configuration items for the mount. @@ -521,6 +515,10 @@ def _create_mount(self, mount_info=None): model = mount_info.get('brand') driver = mount_info.get('driver') + # TODO(jamessynge): We should move the driver specific validation into the driver + # module (e.g. module.create_mount_from_config). This means we have to adjust the + # definition of this method to return a validated but not fully initialized mount + # driver. if model != 'bisque': port = mount_info.get('port') if port is None or len(glob(port)) == 0: