Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra space in ios #45

Closed
lawsonc999 opened this issue Apr 19, 2018 · 20 comments
Closed

Extra space in ios #45

lawsonc999 opened this issue Apr 19, 2018 · 20 comments

Comments

@lawsonc999
Copy link

I implemented pull-to-refresh using this package and worked good.
But I am facing only one problem in ios.
Sometimes after it refresh, the space that activity indicator was placing is not removed in ios.
Please help me to fix it.
Thanks.

@leonvandebroek
Copy link

i am experiencing the same problem. It started about two months ago. Don't know exactly when. Could it be related to iOS 11.3? the problems started right around the time the first beta's were released.

@irreal
Copy link

irreal commented Apr 20, 2018

Can confirm I had this implemented for a long while, made no changes to my code or any nuget package versions, yet it started to leave the empty space where the indicator was.

@msjjd
Copy link

msjjd commented Apr 20, 2018

same problem

@jamesmontemagno
Copy link
Owner

Can you give me sample xaml? Can your repo in the sample in this repo?

@lawsonc999
Copy link
Author

lawsonc999 commented Apr 21, 2018

@jamesmontemagno I've got the exact case that it works wrong.
I have a ContentView in page and I replace 3 different ContentViews to show different layouts in that ContentView.

Here is the ContentView in page

<ContentView
      HorizontalOptions="FillAndExpand"
      VerticalOptions="FillAndExpand"
      x:Name="ContentPresenter"/>

First One in 3 ContentViews has pull-to-refresh layout.

<ContentView.Content>
        <controls:PullToRefreshLayout
            HorizontalOptions="FillAndExpand"
            VerticalOptions="FillAndExpand"
            IsPullToRefreshEnabled="True"
            RefreshCommand="{Binding RefreshHomeProfileCommand}"
            IsRefreshing="{Binding IsLoadingDialogVisible}">
            <ScrollView
                HorizontalOptions="FillAndExpand"
                VerticalOptions="FillAndExpand"
                Padding="15,15,15,15">
                <StackLayout
                    HorizontalOptions="FillAndExpand"
                    VerticalOptions="FillAndExpand"
                    Spacing="15">
                    ....
                    ...
                </StackLayout>
            </ScrollView>
        </controls:PullToRefreshLayout>
</ContentView.Content>

This first layout is default view to show to user in parent ContentView.
When app opens, pull-to-refresh works good and it doesn't have extra space after pull.
But It always have extra space whenever changing ContentViews by clicking button after show other 2 ContentViews.

Please let me know if any misunderstanding.
Thanks and Hope to help to fix issue!

@lawsonc999
Copy link
Author

@jamesmontemagno any update here?

@MrHyde-
Copy link

MrHyde- commented May 3, 2018

Updated our project nuget packages and empty space is now appearing on every refresh. Reverted the package back to the version 2.0.0.13 and everything seems working again.

Then decided to test the 2.2.0 package and the white space isn't appearing either..

Our application supports Android and iOS and the problem is occurring only in the iOS.

@lawsonc999
Copy link
Author

No new version with fixes yet?

@lawsonc999
Copy link
Author

Should I revert back to version 2.0.0.13?

@lawsonc999
Copy link
Author

I am trying to downgrade the package to 2.0.0.13 but no luck, it's not downgraded and shows error.
It's Visual Studio Mac error or package error?
Please help me to fix, thanks.

@tkohub
Copy link

tkohub commented May 11, 2018

Same issue here. Can't fix it with any version (Tried back to 2.0.0.13)

@MrHyde- You managed to get it working with an older version?

@jamesmontemagno
Also reproducible in sample app from repo
https://imgur.com/a/TqPWhwb

@lawsonc999
Copy link
Author

I wasn't able to even revert it to 2.0.0.13. not sure why...

@tkohub
Copy link

tkohub commented May 22, 2018

@jamesmontemagno Can we expect any update on this in the near future? We would be really happy about a fix since we are constantly using the framework and we really like it.

@MrHyde-
Copy link

MrHyde- commented May 28, 2018

@tkohub yes, we have the problem with our project only with the newest package. But the 2.2.0 version works fine for us.

@lawsonc999
Copy link
Author

@MrHyde- do you have release log for this package? I want to know what is difference between 2.2.0 and 2.2.1. You released 2.2.1 very soon after 2.2.0, is there any critical issue in 2.2.0? I am afraid to face another problem with 2.2.0

@jamesmontemagno
Copy link
Owner

does anyone have a screen shot and a small sample?

@jamesmontemagno
Copy link
Owner

Can you please validate: 2.2.1.27-beta and let me know if you see any issues there.

@MrHyde-
Copy link

MrHyde- commented May 30, 2018

For our project the problem does not appear in the beta version. Tested with simulator and real device. Thank you!

@jamesmontemagno
Copy link
Owner

If anyone else can validated I will push 2.2.2 out tonight or tomorrow

@tkohub
Copy link

tkohub commented Jun 4, 2018

Sorry for coming back to you so late, i was on holiday till today.

For me it is working as well! Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants