James on Windows doesn't detect browsers ... but only in PROD

[mitchhentges]

When James is run on Windows, it doesn't show any browsers in the browser list. However, this only occurs after being npm run package'd. When run using npm start, everything is OK.

To reproduce:

1. Start Windows (7 or 10 confirmed)
2. npm run package
3. Start the windows build inbinaries. Both the 32bit and 64bit builds are affected

[tomitm]

Testing out our release packages (win32-x64)...

version	result
1.4.1	✅
1.4.2	✅ *
1.4.3	❌
1.4.4	❌

* 1.4.2 must have an exception, as I'm not seeing any UI at all, just white. .3 and .4 both load properly, but are missing browsers.
[update 5/4] Throwing in the --igv=false fix from 1.4.3 fixes the all white issue, and shows that browsers were loading properly

😕

[tomitm]

Alright, now that I managed to figure out 1.4.2 didn't have the issue, it looks like the problem was introduced in 1.4.3.

We had forked browser-launcher2, and updated win-detect-browsers, which was originally at 1.0.2, now 2.1.0

[mitchhentges]

This will be solved by downgrading win-detect-browsers to 1.0.2 in james-browser-launcher, then using that newer version of james-browser-launcher

[tomitm]

Yep, verified that rolling back win-detect-browsers works out. 👍

[tomitm]

Fixed in 1.4.5.