Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API - it's not clear which options apply to which browsers #81

Open
mitchhentges opened this issue Nov 12, 2018 · 0 comments
Open

Comments

@mitchhentges
Copy link
Member

I don't have a specific solution for how to handle this just yet - just some ideas.
For example, instead of having a single launch(...) function that takes a browser name (plus options), instead, we can have separate functions for each browser type:

  • launchFirefox(...),
  • launchChrome(...)
  • ...

Then, each of these functions could have their own signature?

🤔 not sure the best way to handle this just yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant