Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Karma browser launcher plugins #20

Closed
mitchhentges opened this issue Feb 29, 2016 · 2 comments
Closed

Support Karma browser launcher plugins #20

mitchhentges opened this issue Feb 29, 2016 · 2 comments

Comments

@mitchhentges
Copy link
Member

See how Karma loads plugins
and how each launcher has this launcher:xyz syntax.

This will be super-helpful, especially if james-browser-launcher dies, and a new browser comes out. Rather than attempting to get a PR into james-browser-launcher (though that's awesome, too), a plugin can be used.

@mitchhentges
Copy link
Member Author

A couple things to note:

  1. We can't be like karma and just check the node_modules folder for certain packages. browser-launcher will probably be used in a customer environment, and those don't have node_modules folders. Instead, the consumer of browser-launcher should directly require and provide the karma launchers to browser-launcher.
  2. Each karma browser launcher has some $inject information. Ideally, most of injected things should be mockable, but this might turn out to be a bust.

@mitchhentges
Copy link
Member Author

After looking into this further, it's simply too much.
Karma is very closely tied to Angular (there's some $inject shenanigans) and the plugins themselves are very close to Karma.

A ton of things would need to be mocked out, or copied from Karma - what about current bugs? Do we keep copying Karma's code into browser-laucher? We can't just have Karma as a dependency, that's really weird.

The baseBrowserLauncher is actually a rabbit hole of prototypes and processLaunchers and KarmaEventEmitters. Oh my.

Anways, if someone wants to submit a PR, feel free, but it'll be a fair amount of work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant