Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging, clean code, fix vulnerabilities #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Catharsis68
Copy link

@Catharsis68 Catharsis68 commented Oct 22, 2024

  1. Adding a mode to the connect event - either it's single or high availability mode based on JAMBONES_REDIS_SENTINELS
  2. Put creating the sentinels array in a separate function in utils buildSentinels()
  3. Fix vulnerabilities in package.json via npm audit fix
    3 vulnerabilities (1 moderate, 1 high, 1 critical) => found 0 vulnerabilities

1..100
tests 100
pass 100

ok

let mode = 'single';

if (process.env.JAMBONES_REDIS_SENTINELS) {
mode = 'high availability';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where this mode variable is being used?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 62 - Successfully connected to Redis ${mode} mode

@xquanluu
Copy link
Contributor

Why do we have package-lock.json changes and there is no package.json change?

@Catharsis68
Copy link
Author

Why do we have package-lock.json changes and there is no package.json change?

Fixes within semver range: If npm audit fix can resolve vulnerabilities by updating packages within the version ranges specified in your package.json, it will only update package-lock.json to reflect the new, secure versions. Your package.json won't need changes because the updated versions still satisfy the version constraints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants