Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still maintained? #73

Open
lfolco opened this issue Feb 15, 2021 · 28 comments
Open

Still maintained? #73

lfolco opened this issue Feb 15, 2021 · 28 comments

Comments

@lfolco
Copy link

lfolco commented Feb 15, 2021

Is this project still maintained? Seems to gone quiet for the last 10 months.

@sprankhub
Copy link
Collaborator

This is something, which worries me a bit as well. Especially the lack of feedback regarding certain issues / PRs.

Theoretically, I would be fine with taking over a bit of the maintenance when I get the rights. However, I would like to have a second opinion on many things as well, so I would not like to do it completely on my own.

@jalogut
Copy link
Owner

jalogut commented Feb 16, 2021

Hello, unfortunately I am not maintaining this repo anymore. It's being a while that I do not work with Magento. If you want I can add you as maintainers. Otherwise I will mark the project as deprecated and you can continue your developments on your own forks.

@sprankhub
Copy link
Collaborator

Thanks for your feedback, @jalogut! We rely on this as a basis for all our deployments, so I would like to work on a proper solution here :-)

Then we should:

  1. Find new maintainers for this module. I am in. @lfolco, are you also interested? @osrecio?
  2. [optional] Find a new home for this module. @jalogut, probably you would like to not have it under your name any more, right? We could adopt it and put it under the customgento namespace or we check if FireGento would be interested or...?

@lfolco
Copy link
Author

lfolco commented Feb 16, 2021

I'm game, although I'm not sure I know enough to contribute much (more of a consumer in this situation :D)

@erfanimani
Copy link
Collaborator

I'm happy to help as a maintainer as well, if needed.

@sprankhub
Copy link
Collaborator

Awesome! This means we have a team of (at least) three, nice!

Any opinions regarding the namespace? @jalogut, would you like to keep it in your namespace? Others, what do you think?

@jalogut
Copy link
Owner

jalogut commented Feb 17, 2021

@sprankhub @erfanimani I have added you as maintainers as I know you have been using the tool for a while. I guess you can add other maintainers from now on as well.

Regarding the namespace, for me it makes sense to change it but check it also with @osrecio as he is also a maintainer.

Thanks for your help 😉

@erfanimani
Copy link
Collaborator

Thanks @jalogut!

Regarding the namespace, I don't mind either way. I think the current one is fine too (unless you don't want it under yours any more of course).

@sprankhub
Copy link
Collaborator

Thanks @jalogut! I cannot access any settings of this repository though. Would be good to be able to setup merge checks etc. Could you give me / us more rights?

@sprankhub
Copy link
Collaborator

I just learned from @Schrank that deployer has a Magento 2 recipe in the core of version 7 (currently in beta): https://github.com/deployphp/deployer/blob/master/recipe/magento2.php

For the next project, I will first research that recipe to see if we can use it or if we still need this additional repository.

@jalogut
Copy link
Owner

jalogut commented Feb 25, 2021

Hello @sprankhub

I tried to give you more permissions but unfortunately it is not possible. If you need more rights, I think the best is that you fork this repo into an organisation and continue the development there. Here you could update the readme with the link to the new one. That way, you can also change the namespace and everything you want.

Hope that helps ;)

@rikwillems
Copy link
Contributor

@jalogut @sprankhub @erfanimani I'd be happy to help out. I'm using this with great joy.

@sprankhub
Copy link
Collaborator

Awesome to hear @rikwillems! My current feeling is that it makes more sense to work on the core Deployer 7 Magento 2 recipe instead of caring about this project. Maybe you want to check it out as well :)

@rikwillems
Copy link
Contributor

It would make sense to enhance the Deployer core if there is room for that. Can you point me to that development? I can't find it on the Github page.

@erfanimani
Copy link
Collaborator

@rikwillems
Copy link
Contributor

@erfanimani That was really obvious, sorry about that. My use-case is building in CI and using Deployer Plus to deploy the artifact. That is not in core script. We can add that there too as an option. As said I'm happy to help either in this project or in Deployer core.

@lfolco
Copy link
Author

lfolco commented Jul 27, 2021

Has anyone switched over to just straight Deployer for any of their M2 projects? Curious if it can handle things now or if this repo is still required.

@sprankhub
Copy link
Collaborator

We are using core Deployer to deploy a project via Bitbucket Pipelines. It is not live yet, but the deployment seems to do its job. However, it runs the deployment process on the target server, it does not build a release and then just "copies" the artifact to the target server, which is a better approach I guess...

@rikwillems
Copy link
Contributor

We stopped using Deployer Plus for the build set but are still using it for deployments. The artifact deployments are, by my knowledge, not implemented in Deployer so you would still need Deployer Plus. I can really recommend using the artifacts so you can test and build in CI.

@sprankhub
Copy link
Collaborator

So what we all want and need is artifact deployments in core Deployer 😁 If I just had more time...

@renttek
Copy link
Contributor

renttek commented Mar 15, 2022

Hey @sprankhub, I'd like to contribute some optimizations and wanted to know: what is the current state / plan here?
Do you maintain this or is your focus more on the deployer core recipe for magento 2?

@erfanimani
Copy link
Collaborator

@renttek if I may, I think the focus is on the core recipe for Magento 2. However, quite a few of us are still using and maintaining this, so if you're in the same boat, feel free to contribute here.

@sprankhub
Copy link
Collaborator

I personally try to focus on the core Deployer recipe for Magento 2 in the future. However, old projects of us still use the recipe from this repository. If the changes are not very big, I am happy to review and merge 👍

@renttek
Copy link
Contributor

renttek commented Mar 21, 2022

Okay, thanks for the answer 👍

@akosglue
Copy link

deployer 7 is released and he has nice plans concerning magento artifact upload :)
deployphp/deployer#3206

@erfanimani
Copy link
Collaborator

Just a quick update — artefact deployment seems to be coming soon to the core deployer project (which is the only thing from preventing me switching over to that) deployphp/deployer#3317

@o0mohd0o
Copy link

Hello, is this repo still working?

I want to use it in Magento 2.2.5 any one forked the repo and maintain it?

thanks,

@sprankhub
Copy link
Collaborator

I suggest switching to https://github.com/deployphp/deployer/blob/master/recipe/magento2.php. The switch is not too hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants