Enhancement:Build and deploy identified artifact

[Seb2nim]

Well, actually i'm not big fan of "building" the app on the target server : The "build / deploy-artifact" approach makes more sense to me.

Only issue is that the build actually packages the current application version (local).

Actually the standard Deployer "deploy" can handle branch and tag options...

I think that would make sense to enhance the "build" task to grab (git clone) a specific branch / tag version and package it. Then the "deploy-package" would accept an archive parameter to deploy this specific archive.

This way a tagged version artifact could be deployed on staging server, then, exactly same archive could be deployed to production.

Deploying a developper snapshot version archive (what the tools do right now) would just be a particular scenario of the "archive" deployment mecanism.

[osrecio]

You have the option to use git if you don't use artifact:

https://github.com/jalogut/magento2-deployer-plus/blob/master/deploy.php.sample_2_2#L14-L15

Check it out

[Seb2nim]

Sorry @osrecio, i didn't answer fast enough.

Of course i know...

Sorry, it seems it was not clear :

1. The native "Deployer php" deploy principe is to "pull" code from git repo on the deployment server. (deploy:update_code) : branch, head, tag, etc...
   => Not fan of this : need to have "dev" tools on deploy server, each server compiles its own "version" of app : download composer dependencies, lot of reasons... For me : bad idea.

2. The "artifact-build-deploy" strategy proposed in this project has much more sense to me :

• Build an artifact on a build machine (CI, etc).
• Deploy this artifact on deploy server.

The only "issue" is that the "artifact-build" task actually just packages current local version of the (supposed) repository. It is not capable to build a specific version.

To be more precise, the artifact task DOESNT use git at all : it packs the local folder, whatever is in it and thats all. Thats pretty dangerous...

My suggestion is to rewrite artifact:build to base on update_code :
Download an identified git tree prepare it, the pack it.
Then enhance artifact-deploy to deploy that identified version.

I'll try to share what i've done. Not that simple to create PR as i refactored lot of stuff (version-folder stuff etc...). I'll be back with it this week-end

[osrecio]

I reopened the issue to give you an answer. During this day I will answer you :)

[Seb2nim]

Done, created PR #58. Hope that will help.
Regards