Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8.1 #37

Open
iwiznia opened this issue Jan 3, 2022 · 0 comments · May be fixed by #38
Open

Support for PHP 8.1 #37

iwiznia opened this issue Jan 3, 2022 · 0 comments · May be fixed by #38

Comments

@iwiznia
Copy link

iwiznia commented Jan 3, 2022

The latest version of PHP is 8.1 and this package does not support it.

I forced it to install to see if it would work, but seems that at least all the classes that implement jsonSerializable need to be updated to add a return type.

An example of the error is:

PHP Fatal error: During inheritance of JsonSerializable: Uncaught ErrorException: Return type of ChromeDevtoolsProtocol\Model\Target\CreateBrowserContextRequest::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /chrome-devtools-protocol/gen-src/ChromeDevtoolsProtocol/Model/Target/CreateBrowserContextRequest.php:52

There's also some deprecations like:

PHP Deprecated:  Return type of ChromeDevtoolsProtocol\Model\Network\Headers::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in chrome-devtools-protocol/gen-src/ChromeDevtoolsProtocol/Model/Network/Headers.php on line 75
@iwiznia iwiznia linked a pull request Jan 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant