-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple azure instances #47
base: master
Are you sure you want to change the base?
Conversation
This is super neat! @jakobht can you run the workflow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think it would be nice to add something in the Readme on this - and extend the (sadly few) examples we have.
Just to make clear what can be passed as connection_params
Hi, added a few comments, but generally looks good! The CI failed, the linter is sad. I just updated the build pipelines in master to check 1.16 (but drop 1.11), so please merge. Thanks a lot for the PR! |
e8a643c
to
34fa38d
Compare
Rebased and added some more examples. I've also mentioned this feature briefly in the README. The linter is sad because of unused optional parameters but I haven't touched that section myself. |
{:ok, HTTPoison.Response.t()} | {:error, term()} | ||
def copy_blob(source_name, destination_name, container \\ nil) do | ||
def copy_blob(source_name, destination_name, overrides \\ []) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest documenting that the overrides apply to both source and destination, so you can't use this method to copy between accounts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super important IMO, but documentation is always good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a line in the doc mentioning it
It should be fine to delete the unused args. Sorry I'm slow at answering :) |
This PR has been very helpful for a project I'm working on — thanks! I did notice that |
34fa38d
to
19da24e
Compare
I implemented the same logic for the above function, but in doing so I have made the container optional (ie it defaults to |
Allow passing connection parameters together with the container to blob functions. Values from the parameters are prioritized over default configuration.
4590c69
to
7b028b3
Compare
@jakobht bumping this in case it fell through the cracks. no worries if you've just been too busy to take another look. |
Allow passing connection parameters together with the container to blob functions.
Values from the parameters are prioritized over default configuration.
Fixes #44