Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement required named arguments #74

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

cherusk
Copy link
Contributor

@cherusk cherusk commented Oct 11, 2020

Which issue does this fix?

Closes #{61}
#61

Describe the solution

Leveraged the existing parser and clap feature to allow for setting name args required.

@cherusk cherusk force-pushed the opt_param_required branch from 91d6b4f to 9961304 Compare October 12, 2020 06:13
@jacobdeichert
Copy link
Owner

jacobdeichert commented Oct 13, 2020

@cherusk thanks for this PR.

My time is very limited but I'll try to give it a run this week and aim for a release soon after.

EDIT: haven't had time to look into this yet. On my todo list.

EDIT 2: I'll likely take a look at this in December. Really busy at the moment.

Copy link
Owner

@jacobdeichert jacobdeichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants