Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DEFAULT_JAXWSPROVIDER fallback class name #132

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jGauravGupta
Copy link
Member

Signed-off-by: Gaurav Gupta [email protected]

Seems com.sun.xml.internal.ws.spi.ProviderImpl refactored to com.sun.xml.ws.spi.ProviderImpl earlier but package is not renamed in Provider class.

See the package of ProviderImpl.java.

Copy link
Contributor

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is to be removed instead. Also proper error message should appear if no provider is found.

@lukasj
Copy link
Contributor

lukasj commented Jun 3, 2020

btw: did you check #90 before creating this?

@jGauravGupta jGauravGupta changed the title Fix jakarta.xml.ws.spi.Provider implementation package Remove DEFAULT_JAXWSPROVIDER fallback class name Jun 4, 2020
@jGauravGupta
Copy link
Member Author

Hi @lukasj,

I missed that ticket. Thanks for the suggestions, I have updated PR.

@jGauravGupta jGauravGupta requested a review from lukasj June 4, 2020 07:42
@brcolow
Copy link

brcolow commented Sep 23, 2020

What about adding a static overload to Provider that takes the provider class? Then it could be used thusly:

Provider.provider(com.sun.xml.ws.spi.ProviderImpl.class);

As a side note, I believe the com.sun.xml.ws module should export com.sun.xml.ws.spi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants