Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the cdi-api version be updated? #212

Closed
liweinan opened this issue Apr 19, 2024 · 5 comments
Closed

Can the cdi-api version be updated? #212

liweinan opened this issue Apr 19, 2024 · 5 comments

Comments

@liweinan
Copy link
Contributor

No description provided.

@liweinan
Copy link
Contributor Author

@scottkurz There is `cdi-api 4.1.0' coming out: https://github.com/jakartaee/cdi/releases/tag/4.1.0

And it seems this upgrade can work with JBeret: jberet/jsr352#511

Can this upgrade be included in batch side?

@scottkurz
Copy link
Contributor

scottkurz commented Apr 19, 2024

@liweinan, good question.

Let me first address the process involved.

PROCESS STEPS

First, the specification document doesn't go into a level of detail which would re that would require any doc updates in upgrading, so no issue there.

I still think, according to the JESP, we would need to do a "Service Release" in order to release a new update of the API JAR.
So we'd need to do a PR: https://github.com/jakartaee/specifications/pulls

Ultimately I think the TCK should at least be re-executed against the jbatch impl using the updated API JAR.

USE CASE

That all said, could you please explain what you see as the value here?

I assume you're suggesting to upgrade the dependency version in the 'jakarta.batch-api'. Since this is only a provided-scoped dependency, though, it isn't picked up transitively by consumers of 'jakarta.batch-api'.

I'm curious then how this would help?

@liweinan
Copy link
Contributor Author

Adding @jamezp and @scottmarlow into the loop.

@scottkurz Thanks for the detail explanation!

The reason I'm asking is that I plan to upgrade the cdi-api in JBeret side, and the JBeret itself uses the dependency in its detail implementation(The https://github.com/jberet/jsr352/blob/main/jberet-core/src/main/java/org/jberet/creation/BatchCDIExtension.java for example).

With your teaching and my understanding, as the jakarta.batch-api is a provided scope dependency only in here, I guess I don't have to keep the cdi-api dependency version aligned within JBeret, is that correct?

@scottkurz
Copy link
Contributor

With your teaching and my understanding, as the jakarta.batch-api is a provided scope dependency only in here, I guess I don't have to keep the cdi-api dependency version aligned within JBeret, is that correct?

That's correct. We haven't had any kind of "breaking" compile change in a long time, so it shouldn't be a concern.

@liweinan
Copy link
Contributor Author

@scottkurz Thanks for the answer Scott!

I'll close this issue/question as its confirmed/answered :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants