Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose multiple storages #502

Open
pavolloffay opened this issue Oct 30, 2017 · 2 comments
Open

Docker compose multiple storages #502

pavolloffay opened this issue Oct 30, 2017 · 2 comments

Comments

@pavolloffay
Copy link
Member

#493 introduced docker-compose for cassandra storage.

Further improvements could include support for ES storage. We could have one compose file for jaeger services and one compose file per storage. Storage compose file would define (configs)[https://docs.docker.com/compose/compose-file/#configs] which would be used in the main compose file (Similar what we did in k8s jaegertracing/jaeger-kubernetes#53).

Once this is done we could run crossdock against different storages.

@pavolloffay pavolloffay changed the title Docker compose Docker compose multiple storages Oct 30, 2017
@jpkrohling
Copy link
Contributor

Looks like we have integration tests for ES, but do we have cross dock running against ES?

@yurishkuro
Copy link
Member

yurishkuro commented Apr 2, 2019

I think we should not be running crossdock against any real/heavy storage. We have storage integration tests. End to end tests don't add much to that, since their goal is testing connectivity between components.

But we do need external storage to be shared between collector and query. The path I see is

  • badger PR
  • grpc storage API
  • run badger behind that grpc API as standalone component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants