Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose for deployment of individual components #469

Closed
jpkrohling opened this issue Oct 12, 2017 · 11 comments
Closed

Docker compose for deployment of individual components #469

jpkrohling opened this issue Oct 12, 2017 · 11 comments
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement

Comments

@jpkrohling
Copy link
Contributor

jpkrohling commented Oct 12, 2017

See #466 for context and https://github.com/jaegertracing/jaeger-kubernetes/blob/master/production/jaeger-production-template.yml for reference

This should be done in a separate repository, like there is for Kubernetes and OpenShift.

@jpkrohling
Copy link
Contributor Author

See #306 for a starting point.

@pavolloffay pavolloffay added help wanted Features that maintainers are willing to accept but do not have cycles to implement outreachy labels Oct 12, 2017
@ishanjain28
Copy link

Hi, I'd like to take this up if it is still available.

@sssoleileraaa
Copy link

Note: jaeger-kubernetes/production/jaeger-production-template.yml was renamed to jaeger-kubernetes/production/cassandra.yml (see jaegertracing/jaeger-kubernetes@f930d0a#diff-0b3583916142302afe2c114d88c1f7c1) - Issue description with this reference needs to be updated.

@sssoleileraaa
Copy link

@ishanjain28 are you interested in working together on this?

I was just wondering what name we should give to the new repo. Maybe something like jaeger-compose?

@ishanjain28
Copy link

@AllieOop Yeah, Sure. jaeger-compose sounds good to me.

@pavolloffay
Copy link
Member

@ishanjain28 see #493

@sssoleileraaa
Copy link

sssoleileraaa commented Oct 30, 2017

If I'm understanding this correctly, it sounds like the goal of this issue is to move the docker compose file into a separate repo so that it can be used to support multiple storages. I see the following question asked in #493 (comment): do we want to move the docker compose file into a separate repo? But I don't see any further discussion. If anyone has any thoughts on why this should be done, it would be helpful to discuss it here in this issue, like what storages do we want to support that aren't currently supported, or anything else?

@pavolloffay
Copy link
Member

it sounds like the goal of this issue is to move the docker compose file into a separate repo so that it can be used to support multiple storages.

Compose file can be here on in a different repo and still support different storages.

I think it's easier to have it directly here because:

  • it's used in crossdock - it's automatically tested
  • can more quickly adopt new changes

cc @jpkrohling @yurishkuro

@pavolloffay
Copy link
Member

We can reuse this compose file in different jaeger repositories to run xdock tests:

docker-compose -f https://github.com/jaegertracing/jaeger/master/compose.yml -f $(XDOCK_YAML) run crossdock 

@jpkrohling
Copy link
Contributor Author

I'm not really familiar with how the cross-dock setup works, but docker-compose is an orchestration tool like OpenShift or Kubernetes. If the right place for the compose.yml file is here on this repo, then we might consider moving OpenShift's and Kubernetes' here as well.

@pavolloffay
Copy link
Member

done in #493.

I will open next issue for further improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Features that maintainers are willing to accept but do not have cycles to implement
Projects
None yet
Development

No branches or pull requests

4 participants