Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown by properly handling SIGTERM #295

Closed
jpkrohling opened this issue Jul 28, 2017 · 1 comment · Fixed by #2031 or #2076
Closed

Graceful shutdown by properly handling SIGTERM #295

jpkrohling opened this issue Jul 28, 2017 · 1 comment · Fixed by #2031 or #2076
Assignees
@jpkrohling
Labels
enhancement

Comments

@jpkrohling
Copy link
Contributor

From https://github.com/uber/jaeger/pull/280 :

What I think should happen is you tell the health endpoint to start returning Unavailable and then sleep for a couple seconds, and the exit. The main tchannel / http servers will remain in operation during the sleep and allowed to finish service the in-flight requests, while the routing mesh might hopefully detect health check down and stop sending traffic.
@jpkrohling jpkrohling changed the title Handle SIGTERM Graceful shutdown by properly handling SIGTERM Apr 2, 2019
@jpkrohling jpkrohling mentioned this issue Jan 16, 2020
Closed
@jpkrohling jpkrohling self-assigned this Jan 24, 2020
@jpkrohling jpkrohling mentioned this issue Jan 24, 2020
Merged
@yurishkuro
Copy link
Member

#2076 still pending.

@yurishkuro yurishkuro reopened this Feb 24, 2020
@jpkrohling jpkrohling mentioned this issue Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved graceful shutdown - Agent
Improved graceful shutdown - Collector
2 participants
@jpkrohling @yurishkuro