Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd compression support for Kafka storage #2824

Closed
arnitolog opened this issue Feb 22, 2021 · 4 comments · Fixed by #2907
Closed

zstd compression support for Kafka storage #2824

arnitolog opened this issue Feb 22, 2021 · 4 comments · Fixed by #2907
Labels
bug good first issue Good for beginners

Comments

@arnitolog
Copy link

Describe the bug
I started to see the error below as soon as I enabled zstd compression on the collector side.
We are on jaeger 1.19.2 and Kafka 2.5.0

{"level":"error","ts":1613990679.9162657,"caller":"kafka/writer.go:58","msg":"zstd compression requires building with cgo enabled","stacktrace":"github.com/jaegertracing/jaeger/plugin/storage/kafka.NewSpanWriter.func2\n\tgithub.com/jaegertracing/jaeger/plugin/storage/kafka/writer.go:58"}

To Reproduce
Steps to reproduce the behavior:

  1. configure zstd compression for kafka

Have I missed something? Will upgrade to the latest Jaeger will help here?

@arnitolog arnitolog added the bug label Feb 22, 2021
@jpkrohling
Copy link
Contributor

If it requires cgo, we will probably remove support for this feature.

@jpkrohling jpkrohling added the good first issue Good for beginners label Feb 22, 2021
@arnitolog
Copy link
Author

as far as I can see sarama has switched from cgo to pure Go implementation for zstd in 1.24.0: https://github.com/Shopify/sarama/blob/master/CHANGELOG.md#version-1240-2019-10-09
IBM/sarama#1477

@jpkrohling
Copy link
Contributor

In which case, we might want to bump the dependency. Would you like to give it a try?

@arnitolog
Copy link
Author

yeah, will try to build it locally and see how it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants