Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jaeger collector crashed accidentally due to samara return nil error #2653

Closed
Betula-L opened this issue Nov 26, 2020 · 0 comments · Fixed by #2654
Closed

Jaeger collector crashed accidentally due to samara return nil error #2653

Betula-L opened this issue Nov 26, 2020 · 0 comments · Fixed by #2654
Labels

Comments

@Betula-L
Copy link
Contributor

Describe the bug
Collector panic when print error log since e.Err is nil.

logger.Error(e.Err.Error())

It may be caused by sarama bug which return unexpected nil to error channel. It's hard to track the root cause of sarama sdk.

https://github.com/Shopify/sarama/blob/0616f68815691527d3b6ab4d95a2881e09400fe3/async_producer.go#L1072

Expected behavior

However, jaeger should not concern about it, just wrap e.Err.

Do not panic collector because of kafka sdk bug.

Version (please complete the following information):

  • OS: Linux
  • Jaeger version: v1.16.0
  • Deployment: Docker

Additional context

panic logs:

env:prod
log:panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x10aca5f]
goroutine 42 [running]:
github.com/jaegertracing/jaeger/plugin/storage/kafka.NewSpanWriter.func1(0x161c860, 0xc00079e310, 0xc00010ac00, 0x15f4c80, 0xc000386ce0, 0x15f4c80, 0xc000386d50)
	github.com/jaegertracing/jaeger/plugin/storage/kafka/writer.go:54 +0x12f
created by github.com/jaegertracing/jaeger/plugin/storage/kafka.NewSpanWriter
	github.com/jaegertracing/jaeger/plugin/storage/kafka/writer.go:50 +0x273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant