Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TChannel from agent->collector path #2129

Closed
yurishkuro opened this issue Mar 16, 2020 · 3 comments · Fixed by #2308
Closed

Remove TChannel from agent->collector path #2129

yurishkuro opened this issue Mar 16, 2020 · 3 comments · Fixed by #2308
Assignees

Comments

@yurishkuro
Copy link
Member

@pavolloffay I created a new internal build that uses a local copy of the /tchannel packages you created (#2105), and deployed it today. All metrics look good. I think we can start removing the code.

@ghost ghost added the needs-triage label Mar 16, 2020
@pavolloffay
Copy link
Member

Do you want to submit a PR? If no I can do that.

@yurishkuro
Copy link
Member Author

Go for it, I won't be able to get to it soon.

One thing I wanted to watch out was making sure we don't leave other dead code around. For example, pkg/discovery may be only used from tchannel.

@pavolloffay
Copy link
Member

I am wondering whether full removal would break OTEL collector they are exposing tchannel exporter.

Afther quick inspection it looks that they are not using tchannel from agent or the new tchannel package cc) @objectiser
https://github.com/open-telemetry/opentelemetry-collector/pull/636/files#diff-0e6ca11168918e81d990fd9005b9671cL45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants