Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of log indexing #1905

Closed
joe-elliott opened this issue Nov 7, 2019 · 2 comments · Fixed by #1915
Closed

Allow disabling of log indexing #1905

joe-elliott opened this issue Nov 7, 2019 · 2 comments · Fixed by #1915
Assignees

Comments

@joe-elliott
Copy link
Member

joe-elliott commented Nov 7, 2019

Requirement - what kind of business use case are you trying to solve?

In order to increase spans throughput to Cassandra we need more control over what is indexed. Currently all logs are being indexed. Once #1904 is merged we will have more control, but it would be nice to just disable log indexing all together.

Problem - what in Jaeger blocks you from solving the requirement?

There is a partial implementation already: https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/cassandra/spanstore/dbmodel/log_fields_filter.go

It just needs to be exposed as a configuration option.

Proposal - what do you suggest to solve the problem or improve the existing situation?

Add a boolean configuration option to the Cassandra backend index-logs that defaults to true.

Any open questions to address

None

@joe-elliott
Copy link
Member Author

joe-elliott commented Nov 7, 2019

I would be glad to begin working on this as soon as #1904 is merged. The changes touch some of the same areas.

@yurishkuro
Copy link
Member

NB: while the CLI flag could be "positive" ("enable"), the struct field should be negative (DisableLogIndexing) so that the default behavior of the storage doesn't change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants