Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL verification mode parameter for rollover script #1898

Closed
weeco opened this issue Nov 5, 2019 · 1 comment
Closed

Add SSL verification mode parameter for rollover script #1898

weeco opened this issue Nov 5, 2019 · 1 comment

Comments

@weeco
Copy link

weeco commented Nov 5, 2019

Problem - what in Jaeger blocks you from solving the requirement?

Currently it is possible to specify TLS certificates, but it isn't possible to specify the verification mode for Elasticsearch here: https://github.com/jaegertracing/jaeger/blob/d85776db9cce72ae714da89dbd09e5dcea9eddb4/plugin/storage/es/esRollover.py

Since I only want to run this once, I'd usually go ahead and port forward one of the elasticsearch nodes and execute the script against localhost using the docker run command. Unfortunately I'd need to mount the CA certificate into the container now, which makes it more cumbersome to execute.

Instead I'd like to set the SSL verification mode to none for the setup request. It should be fairly simple to add a parameter to the script and use that for the connection.

@pavolloffay
Copy link
Member

done in #1918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants