Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UI ability to collapse spans below threshold #1724

Closed
roippi opened this issue Aug 8, 2019 · 1 comment
Closed

add UI ability to collapse spans below threshold #1724

roippi opened this issue Aug 8, 2019 · 1 comment

Comments

@roippi
Copy link

roippi commented Aug 8, 2019

Requirement

When I view a trace, I would like the option to collapse all parent spans with duration less than some configurable threshold.

Problem

The default trace view expands all spans by default.

#1552 proposed dropping spans below some threshold. This is not what I want - I do like that these small spans are there; they just take up a lot of vertical space and make the default trace view very tall. I'd like to see them only when I drill in.

I can manually collapse spans to get a view that I'd like, but this is time consuming and requires some training of engineers to help them get the most out of the tool.

Proposal - what do you suggest to solve the problem or improve the existing situation?

A query param to be provided for trace view to switch on this behavior, eg ?collapseBelow=100ms. Exact syntax to be bikeshedded :)

@roippi
Copy link
Author

roippi commented Aug 8, 2019

Realized this belongs in the UI repo. I'll close and reopen over there. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant