-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support trace view as a flame graph #525
Comments
The flame-graph kind of view is not supported in Jaeger. |
The challenge with this type of view is that sibling spans are not guaranteed to not overlap, so how should they be displayed in that case?
|
Yes.. I didn't think that part. Datadog's tracing view can be hint for this problem. (they have implemented flame graph with open tracing ) And, Overlapped graph can be great help to developer if developer set kinds of |
DD docs don't explain how the they deal with overlapping siblings, unless I missed it |
Right , closed this issue because of the challenge of |
I think this issue should be reopened. Flamegraph support for jaeger would be really useful for some of the systems I'm working with. This tool takes a JSON dump from jaeger and converts it to be read by FlameGraph: https://github.com/symbiont-io/jaeger-flamegraph Might be some clues there for how to handle the overlapping siblings? I'd be interested in working on a PR for this if there's appetite for it? |
FWIW, I'd really like this feature too. The sibling overlapping issue is a small edge case you can handle by just putting them on different rows. It's fine - parallel work is just messy. Basically the entire logic is that spans should go on a new row if there is no room on a preceding row and never going higher than a parent. I've made and used a basic viewer like this in the past and it worked great. |
+1 |
+2 |
I am implementing jaeger, it really looks nice.
But I got a problem.
I want to collect spans on one line in tracing view, but I cannot find way.
[As-IS]
[To-Be]
Maybe I can't find the doc... could you help ?
The text was updated successfully, but these errors were encountered: