Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure max limit result in SearchForm.js #478

Closed
GabrielDyck opened this issue Nov 2, 2019 · 2 comments · Fixed by #511
Closed

Configure max limit result in SearchForm.js #478

GabrielDyck opened this issue Nov 2, 2019 · 2 comments · Fixed by #511

Comments

@GabrielDyck
Copy link
Contributor

Requirement - what kind of business use case are you trying to solve?

Hello!
I want to configure searchform "Limit Results" max property.

Problem - what in Jaeger blocks you from solving the requirement?

I navigated the code and saw that is hardcoded 1500 as max limit in SearchForm.js

Proposal - what do you suggest to solve the problem or improve the existing situation?

I think we can configure like environmet value the max limit, and if isn't configured, we can set 1500 as default value.

What do you think?

Thank you !

@everett980
Copy link
Collaborator

@GabrielDyck This definitely seems like a reasonable change.

You can add a field to the config.search called maxLimit, and add the current value as the default in the default config. Then call getConfig('search.maxLimit') on this line.

@GabrielDyck
Copy link
Contributor Author

Hi @everett980 !
I've just created a pull request with the changes.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants