Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS error on search page after viewing 404 trace #166

Closed
tiffon opened this issue Jan 8, 2018 · 0 comments
Closed

JS error on search page after viewing 404 trace #166

tiffon opened this issue Jan 8, 2018 · 0 comments
Assignees
Labels

Comments

@tiffon
Copy link
Member

tiffon commented Jan 8, 2018

Description

Navigating from a trace page that is 404 (trace not found) to the search page results in a JS error.

Steps to reproduce the issue:

  1. Visit a trace page that does not exist, e.g. /trace/000
  2. Click the "Search" button in the top nav

Describe the results you received:

The page does not change and the following JS error is logged:

Uncaught TypeError: Cannot read property 'length' of undefined
    at o (search.js:43)
    at Array.map (<anonymous>)
    at a (search.js:88)
    at index.js:209
    at get-last-xform-cacher.js:38
    at Function.a [as mapToProps] (index.js:232)
    at r (wrapMapToProps.js:43)
    at Function.r.mapToProps (wrapMapToProps.js:52)
    at r (wrapMapToProps.js:43)
    at o (selectorFactory.js:26)

Describe the results you expected:

The search page is presented without error.

@tiffon tiffon added the bug label Jan 8, 2018
@tiffon tiffon self-assigned this Jan 8, 2018
@tiffon tiffon removed their assignment Feb 1, 2018
@tiffon tiffon removed the SimonRobb label Mar 12, 2018
@ghost ghost assigned tiffon Mar 12, 2018
@ghost ghost added the review label Mar 12, 2018
@ghost ghost removed the review label Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant