Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HotROD traces display without trace name #149

Closed
yurishkuro opened this issue Dec 22, 2017 · 6 comments
Closed

HotROD traces display without trace name #149

yurishkuro opened this issue Dec 22, 2017 · 6 comments
Assignees
Labels

Comments

@yurishkuro
Copy link
Member

@tiffon I just tried the latest UI and saw this

image

@yurishkuro
Copy link
Member Author

This could be a server-side issue, the root span doesn't look right, span reference with traceID=0 is invalid

        {
          "traceID": "3fb3f396b13217b",
          "spanID": "3fb3f396b13217b",
          "flags": 1,
          "operationName": "HTTP GET /dispatch",
          "references": [
            {
              "refType": "CHILD_OF",
              "traceID": "0",
              "spanID": "0"
            }
          ],

@tiffon
Copy link
Member

tiffon commented Dec 22, 2017

I've been running the latest UI with a prior all-in-one and haven't noticed the issue. I'll confirm, though.

@yurishkuro
Copy link
Member Author

I'm pretty sure it's an issue on the server, when I use memory store I see it getting spans with above reference (traceID==0, invalid). I'm still looking where exactly it's being added, by the client or the server enrichment.

@yurishkuro
Copy link
Member Author

Confirmed that the issue is in the Go client (jaegertracing/jaeger-client-go#242) that sends a bad reference {"refType":"CHILD_OF","traceIdLow":0,"traceIdHigh":0,"spanId":0} when baggage is provided externally to the root span.

@tiffon
Copy link
Member

tiffon commented Dec 23, 2017

Is there a change necessary in the UI?

@yurishkuro
Copy link
Member Author

no, just the backend - jaegertracing/jaeger#614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants