Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRD generator creates a list of CRDs instead of a single CRD #977

Closed
jpkrohling opened this issue Mar 18, 2020 · 0 comments · Fixed by #978
Closed

CRD generator creates a list of CRDs instead of a single CRD #977

jpkrohling opened this issue Mar 18, 2020 · 0 comments · Fixed by #978
Assignees
@jpkrohling
Labels
bug Something isn't working

Comments

@jpkrohling
Copy link
Contributor

In previous versions, the Jaeger Operator used the operator-sdk to generate CRDs. As part of #932, we changed it to use the controller-gen, which writes a list of CRDs to the output, instead of a single CRD as it was before with the operator-sdk. Although the YAML file is still valid, it causes problems with other Operator SDK tooling, such as OLM.
@jpkrohling jpkrohling self-assigned this Mar 18, 2020
@ghost ghost added the needs-triage New issues, in need of classification label Mar 18, 2020
@jpkrohling jpkrohling added bug Something isn't working and removed needs-triage New issues, in need of classification labels Mar 18, 2020
@jpkrohling jpkrohling mentioned this issue Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change 'make generate' to write only a single CRD jpkrohling/jaeger-operator
1 participant
@jpkrohling