Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource limits not applied for jaeger-agent sidecar #342

Closed
jkandasa opened this issue Mar 21, 2019 · 2 comments
Closed

Resource limits not applied for jaeger-agent sidecar #342

jkandasa opened this issue Mar 21, 2019 · 2 comments

Comments

@jkandasa
Copy link
Member

I applied resource limits for all the services. Limits applied for collector and query service.
But limits not applied for jaeger-agent sidecar.

image

query-pod-describe.txt

My CR:

apiVersion: jaegertracing.io/v1
kind: Jaeger
metadata:
  name: jaegerqe
spec:
  ingress:
    security: none
  strategy: production
  collector:
    replicas: 1
    image: jaegertracing/jaeger-collector:1.11
    resources:
      requests:
        cpu: "1"
        memory: "1Gi"
      limits:
        cpu: "1"
        memory: "1Gi"
    options:
      log-level: debug
      metrics-backend: expvar
      collector:
        num-workers: 100
        queue-size: 20000
      es:
        bulk:
          size: 500000
          workers: 50
          flush-interval: 220ms
  query:
    replicas: 1
    image: jaegertracing/jaeger-query:1.11
    resources:
      requests:
        cpu: "100m"
        memory: "128Mi"
      limits:
        cpu: "500m"
        memory: "512Mi"
    options:
      log-level: debug
      metrics-backend: expvar
      query:
        port: 16686
  agent:
    strategy: sidecar
    image: jaegertracing/jaeger-agent:1.11
    resources:
      requests:
        cpu: "100m"
        memory: "128Mi"
      limits:
        cpu: "500m"
        memory: "512Mi"
    options:
      log-level: debug
      metrics-backend: expvar
      processor:
        jaeger-compact:
          server-queue-size: 100000
          workers: 101
  storage:
    type: elasticsearch
    esIndexCleaner:
      enabled: false
    dependencies:
      enabled: false
    options:
      es:
        server-urls: http://elasticsearch:9200
@objectiser
Copy link
Contributor

There is a PR to cover sidecar agent: #169

@TBBle
Copy link
Contributor

TBBle commented Feb 27, 2020

For anyone who comes across this later, the actual feature was delivered in #401, as #169 was never merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants