Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl get pods and logs commands in README don't work because of label changes #224

Closed
kevinearls opened this issue Feb 22, 2019 · 2 comments

Comments

@kevinearls
Copy link
Contributor

The README includes the following commands

kubectl get pods -l jaeger=simplest
kubectl logs -l jaeger=simplest

Currently neither of these work as the jaeger label doesn't exist. As a workaround we can do:

kubectl get pods -l app.kubernetes.io/instance=simplest
kubectl logs -l app.kubernetes.io/instance=simplest

NOTE: On Openshift the kubectl logs command also requires that the container name be specified.

@jpkrohling
Copy link
Contributor

The question is whether we want to add a label "jaeger" again, to make it easier to query the objects related to simplest. The same can be done by querying based on the label app.kubernetes.io/instance, but that's a lot more work than just typing jaeger.

@jpkrohling
Copy link
Contributor

Done as part of #225, we won't be re-adding the jaeger entry for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants