Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Query Ingress not properly created with streaming strategy #2088

Closed
erdody opened this issue Oct 11, 2022 · 1 comment · Fixed by #2120
Closed

[Bug]: Query Ingress not properly created with streaming strategy #2088

erdody opened this issue Oct 11, 2022 · 1 comment · Fixed by #2120
Labels
bug Something isn't working

Comments

@erdody
Copy link

erdody commented Oct 11, 2022

What happened?

If you define a path in jaeger query, that path is used for the ingress in deployment strategy == production.
The same doesn't happen if you switch to deployment strategy == streaming.

https://github.com/jaegertracing/jaeger-operator/blob/v1.38.0/pkg/ingress/query.go#L86

Steps to reproduce

  1. Create a Jaeger with production strategy, and set a base path in query. Something like:
spec:
  strategy: production
  query:
    options:
      query:
        base-path: /jaeger
...

you'll see an ingress with a rule similar to this:

spec:
  rules:
  - http:
      paths:
      - backend:
          service:
            name: jaeger-query
            port:
              number: 16686
        path: /jaeger
        pathType: ImplementationSpecific
  1. Do the same with strategy: streaming

Now the ingress only has a default backend service:

spec:
  defaultBackend:
    service:
      name: jaeger-query
      port:
        number: 16686

Expected behavior

The ingress should not be different.

Relevant log output

No response

Screenshot

No response

Additional context

No response

Jaeger backend version

1.38.0

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

kubernetes

Deployment configs

No response

@erdody erdody added the bug Something isn't working label Oct 11, 2022
@frzifus
Copy link
Member

frzifus commented Nov 2, 2022

@rubenvp8510 @kevinearls are you interested in this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants