Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse io.jaegertracing apiGroup #201

Closed
pavolloffay opened this issue Feb 8, 2019 · 3 comments
Closed

Reverse io.jaegertracing apiGroup #201

pavolloffay opened this issue Feb 8, 2019 · 3 comments
Assignees
@jpkrohling

Comments

@pavolloffay
Copy link
Member

The API groups are usually in the following form:

  • monitoring.coreos.com
  • rbac.authorization.k8s.io/v1
  • route.openshift.io

and we use io.jaegertracing

we should reconsider and change to jaegertracing.io
@jpkrohling
Copy link
Contributor

I wonder if this pattern/convention is documented somewhere

@pavolloffay
Copy link
Member Author

Not sure if directly documented but all the examples use the sub-resource.resource.domain group: https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/

@pavolloffay pavolloffay mentioned this issue Feb 26, 2019
Closed
4 tasks
@jpkrohling jpkrohling mentioned this issue Feb 28, 2019
Merged
@jpkrohling jpkrohling self-assigned this Mar 4, 2019
@jpkrohling
Copy link
Contributor

Done as part of #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @pavolloffay