-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log line inconsistency #1817
Comments
What do you think about adding something to ensure the logging is not done using |
sure, what did you have in mind? Some kind of linting rule? I wouldn't prioritize it too highly, but it would certainly be helpful. |
Yes. Something like looking for usages of |
I'm not sure if this will adequately address the issue. Imports are often renamed. Found this in cmd/generate. e.g. log "github.com/sirupsen/logrus" |
Where is the |
Describe the bug
Seems we use plain
logrus
in some places instead of the propagatedlogr.Logger
wrapper. on one hand this leads to bad readability, on the other hand i had problems to change the log level in all places at once.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Screenshots

Version (please complete the following information):
The text was updated successfully, but these errors were encountered: