Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log when dependency job is enabled with unsupported storage #157

Closed
jpkrohling opened this issue Dec 4, 2018 · 0 comments
Closed

Log when dependency job is enabled with unsupported storage #157

jpkrohling opened this issue Dec 4, 2018 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jpkrohling
Copy link
Contributor

Follow-up from #140: that PR adds a log.Info on the default case (Enabled=false for Cassandra and ES), while it doesn't let the user know that the dependency job isn't installed when Enabled=true and storage isn't Cassandra or ES.

It should:

  1. Not log anything on the standard, common case. If everything is as it should, there's no need to log anything
  2. Log (debug or info) when Enabled=true and the storage isn't ES or Cassandra. This is because the flag is false by default, meaning that the user has explicitly set the value to true, so, there's a clear expectation that the job will be installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant