Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC port for jaeger-query into its Service resource #1520

Closed
anhdle14 opened this issue Jul 30, 2021 · 3 comments · Fixed by #1521
Closed

Add gRPC port for jaeger-query into its Service resource #1520

anhdle14 opened this issue Jul 30, 2021 · 3 comments · Fixed by #1521
Assignees
Labels
bug Something isn't working

Comments

@anhdle14
Copy link

anhdle14 commented Jul 30, 2021

Requirement - what kind of business use case are you trying to solve?

I am trying to set up integration via GRPC with Kiali and Jaeger within an Istio-mesh K8s cluster.

  • kiali – v1.37.0
  • istio – v1.10.3
  • jaeger-operator– v1.24.0
    • The CR is a simple AllInOne with no addtional config.

Problem - what in Jaeger blocks you from solving the requirement?

Kiali from v1.37.0 expects the communication port with Jaeger via RPC (16685). In Kiali-operator PR#370.

It was a pain to debug this but here is the list of problems:

  • Pod/SVC of jaeger do not expose 16685 by default.
    NAME                      READY   STATUS    RESTARTS   AGE
    jaeger-64bf49b557-ddtlm   1/1     Running   0          89m
    
    NAME           TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)     AGE
    jaeger-query   ClusterIP   10.101.138.58   <none>        16686/TCP   88m
  • The CRDs do not support adding additional ports for both SVC and Deployment of Jaeger. At least from what I can see in here: pkg.go.dev/jaegertracing/jaeger-operator
  • There is no easy way to reference a full list of supported CR. And Document CR with all the options #671 should be the priority for new people to actually see what are available. And not by going through a go code.

Proposal - what do you suggest to solve the problem or improve the existing situation?

  • The easiest way to fix it is: Creating another SVC to expose 16685. Although Pod do not expose 16685, but it will work.. I kind of remember that from reading the K8s docs.
  • Adding more granular configuration to all the SVC, Deployment of Jaeger.
  • Or support kustomize patch manifests folder with raw k8s yaml.

Any open questions to address

N/A

@jpkrohling
Copy link
Contributor

We should be opening the gRPC port by default for jaeger-query.

@jpkrohling jpkrohling added the bug Something isn't working label Aug 2, 2021
@jpkrohling jpkrohling changed the title Support additional ports to be set via CRDs to jaeger deployment.apps Add gRPC port for jaeger-query into its Service resource Aug 2, 2021
@anhdle14
Copy link
Author

anhdle14 commented Aug 4, 2021

I think it is more than just adding the query grpc port, It is about allow user to at least patch the resources via the operator. It is ok if there is already an issue for this.

@jpkrohling
Copy link
Contributor

The operator owns the resources it creates, and allowing users to patch it out of band will break this premise. In this particular case, we recommend users to have their own service, managed externally to the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants