Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing apps with sidecar agent inject annotation not injected when first appropriate jaeger instance created #1315

Closed
objectiser opened this issue Nov 25, 2020 · 3 comments · Fixed by #1334
Assignees
Labels
needs-triage New issues, in need of classification

Comments

@objectiser
Copy link
Contributor

If an app has been deployed, before the Jaeger instance is created, the operator log shows:

"No suitable Jaeger instances found to inject a sidecar" deployment=myapp

However, when the Jaeger instance is created (and available), the operator does not rescan the apps to see whether an agent for that Jaeger instance can now be injected.

Reproduced on OCP4.5 with Jaeger 1.17 and 1.20.

@github-actions github-actions bot added the needs-triage New issues, in need of classification label Nov 25, 2020
@objectiser
Copy link
Contributor Author

cc @jpkrohling @rubenvp8510

Haven't tried on latest, as was not available in the operatorhub at the time, so might be fixed?

Also tried with app having injected sidecar, then removed the jaeger instance (which cleaned up the sidecar agent), and then created a new jaeger instance - and the agent doesn't get re-injected into the app.

BTW - the Jaeger instance and business app are deployed to different namespaces.

@jpkrohling
Copy link
Contributor

jpkrohling commented Nov 25, 2020

There were quite a few changes made by @rubenvp8510 in the past on this logic, so, this might indeed be fixed already. But would be nice to get a confirmation from him.

BTW - the Jaeger instance and business app are deployed to different namespaces.

This shouldn't be a problem: I just tested a scenario with Jaeger deployed in istio-system and it was able to inject a sidecar in a deployment in service-mesh-arena.

@rubenvp8510
Copy link
Collaborator

I changed the logic to address the case of injection across namespaces. and IIRC I put some logic to scan apps for injection
I'll check this case and see if can reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage New issues, in need of classification
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants