Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readiness probes missing from the injected sidecar container #1202

Closed
chgl opened this issue Sep 20, 2020 · 1 comment · Fixed by #2077
Closed

Readiness probes missing from the injected sidecar container #1202

chgl opened this issue Sep 20, 2020 · 1 comment · Fixed by #2077
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@chgl
Copy link
Contributor

chgl commented Sep 20, 2020

The injected sidecar agent currently does not set either a readiness or liveness probe. The other deployment types do:

https://github.com/jaegertracing/jaeger-operator/blob/master/pkg/deployment/agent.go#L156-L175
@ghost ghost added the needs-triage New issues, in need of classification label Sep 20, 2020
@jpkrohling jpkrohling added enhancement New feature or request good first issue Good for newcomers hacktoberfest and removed needs-triage New issues, in need of classification labels Sep 21, 2020
@kadern0 kadern0 mentioned this issue Oct 2, 2020
Closed
@frzifus
Copy link
Member

frzifus commented Jun 24, 2022

Liveness probe got added here: #1605

@frzifus frzifus changed the title Liveness and readiness probes missing from the injected sidecar container Readiness probes missing from the injected sidecar container Jun 24, 2022
@MacroPower MacroPower mentioned this issue Sep 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
3 participants
@jpkrohling @chgl @frzifus