Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl explain does not work on CRD #1014

Open
harpratap opened this issue Apr 10, 2020 · 5 comments
Open

Kubectl explain does not work on CRD #1014

harpratap opened this issue Apr 10, 2020 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@harpratap
Copy link

harpratap commented Apr 10, 2020

The jaegers.jaegertracing.io API returns empty when doing kubectl explain jaeger
But it should return at least the spec, if not also the description.

I understand the reasoning behind removing the descriptions in #932 but an alternative should be provided where it is easy to read the entire API definition with explanation like in kubectl explain or in the way Istio does this for their operator - https://istio.io/docs/reference/config/istio.operator.v1alpha1/

@ghost ghost added the needs-triage New issues, in need of classification label Apr 10, 2020
@objectiser objectiser removed the needs-triage New issues, in need of classification label Apr 14, 2020
@objectiser
Copy link
Contributor

@harpratap Would you be interested in contributing a PR to fix this?

@izelnakri
Copy link

Hi there, yes this feature is absolutely needed. I'm currently confused on where to look for the Jaeger CRD API, wanted to check all the storage configurations but stuck because kubectl explain Jaeger.spec.storage returns empty description.

@izelnakri
Copy link

What is suggested here will increase use when implemented, and it will help finding bugs as well, I think I found one with cassandra storage for example.

@objectiser
Copy link
Contributor

@izelnakri This is probably due to the description fields being stripped from the CRD, which was necessary due to its size - when using kubectl apply it failed. See #854.

@esnible
Copy link
Contributor

esnible commented Sep 14, 2021

The structure seems visible when I do kubectl explain jaeger or kubectl explain jaeger.spec or kubectl explain jaeger.spec.collector.

The description fields are not present. Is this Issue a request for field descriptions, or do you not see the structure at all?

@frzifus frzifus added the help wanted Extra attention is needed label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants