From f96b4384a670f0174a31a007b5a4ff47869accb8 Mon Sep 17 00:00:00 2001
From: Ruben Vargas <ruben.vp8510@gmail.com>
Date: Sat, 10 Jul 2021 00:12:25 -0500
Subject: [PATCH] Add flags to enable/disable operand metrics

Signed-off-by: Ruben Vargas <ruben.vp8510@gmail.com>
---
 pkg/cmd/start/main.go    |  1 +
 pkg/metrics/bootstrap.go | 57 ++++++++++++++++++++++------------------
 2 files changed, 32 insertions(+), 26 deletions(-)

diff --git a/pkg/cmd/start/main.go b/pkg/cmd/start/main.go
index df3ba6b91..893d95a45 100644
--- a/pkg/cmd/start/main.go
+++ b/pkg/cmd/start/main.go
@@ -57,6 +57,7 @@ func NewStartCommand() *cobra.Command {
 	cmd.Flags().Int32("cr-metrics-port", 8686, "The metrics port for Operator and/or Custom Resource based metrics")
 	cmd.Flags().String("jaeger-agent-hostport", "localhost:6831", "The location for the Jaeger Agent")
 	cmd.Flags().Bool("tracing-enabled", false, "Whether the Operator should report its own spans to a Jaeger instance")
+	cmd.Flags().Bool("operand-metrics-enabled", false, "Whether the Operator should report metrics about the operands.")
 
 	return cmd
 }
diff --git a/pkg/metrics/bootstrap.go b/pkg/metrics/bootstrap.go
index 7fb3752ab..971549daf 100644
--- a/pkg/metrics/bootstrap.go
+++ b/pkg/metrics/bootstrap.go
@@ -3,6 +3,8 @@ package metrics
 import (
 	"context"
 
+	"github.com/spf13/viper"
+
 	prometheusclient "github.com/prometheus/client_golang/prometheus"
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
@@ -25,33 +27,36 @@ const meterName = "jaegertracing.io/jaeger"
 
 // Bootstrap configures the OpenTelemetry meter provides with the prometheus exporter
 func Bootstrap(ctx context.Context, namespace string, client client.Client) error {
-	tracer := otel.GetTracerProvider().Tracer(v1.BootstrapTracer)
-	ctx, span := tracer.Start(ctx, "bootstrap")
-	defer span.End()
-	tracing.SetInstanceID(ctx, namespace)
-
-	config := prometheus.Config{
-		Registry: metrics.Registry.(*prometheusclient.Registry),
-	}
-	c := controller.New(
-		processor.New(
-			selector.NewWithHistogramDistribution(
-				histogram.WithExplicitBoundaries(config.DefaultHistogramBoundaries),
+	if viper.GetBool("operand-metrics-enabled") {
+		tracer := otel.GetTracerProvider().Tracer(v1.BootstrapTracer)
+		ctx, span := tracer.Start(ctx, "bootstrap")
+		defer span.End()
+		tracing.SetInstanceID(ctx, namespace)
+
+		config := prometheus.Config{
+			Registry: metrics.Registry.(*prometheusclient.Registry),
+		}
+		c := controller.New(
+			processor.New(
+				selector.NewWithHistogramDistribution(
+					histogram.WithExplicitBoundaries(config.DefaultHistogramBoundaries),
+				),
+				export.CumulativeExportKindSelector(),
+				processor.WithMemory(true),
 			),
-			export.CumulativeExportKindSelector(),
-			processor.WithMemory(true),
-		),
-		controller.WithResource(resource.NewWithAttributes([]attribute.KeyValue{}...)),
-	)
-	exporter, err := prometheus.NewExporter(config, c)
-	if err != nil {
+			controller.WithResource(resource.NewWithAttributes([]attribute.KeyValue{}...)),
+		)
+		exporter, err := prometheus.NewExporter(config, c)
+		if err != nil {
+			return tracing.HandleError(err, span)
+		}
+
+		global.SetMeterProvider(exporter.MeterProvider())
+
+		// Create metrics
+		instancesObservedValue := newInstancesMetric(client)
+		err = instancesObservedValue.Setup(ctx)
 		return tracing.HandleError(err, span)
 	}
-
-	global.SetMeterProvider(exporter.MeterProvider())
-
-	// Create metrics
-	instancesObservedValue := newInstancesMetric(client)
-	err = instancesObservedValue.Setup(ctx)
-	return tracing.HandleError(err, span)
+	return nil
 }