You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Implementations like tally, prom, go-kit, influx and expvar support float64 gauges, but jaeger-lib casts the int64 to a float64 value. Is there a reason for this?
Update Gauge to use float64 instead of int64 in jaeger-lib 3.0; alternatively jaeger-lib can declare new types GaugeV2, FactoryV2, etc and create an adaptor.
The text was updated successfully, but these errors were encountered:
Requirement
We would like to emit gauge updates with floating numbers (e.g. probabilities)
Problem
The gauge interface in jaeger-lib only supports
int64
jaeger-lib/metrics/gauge.go
Lines 18 to 21 in 78a0e7f
Implementations like tally, prom, go-kit, influx and expvar support
float64
gauges, butjaeger-lib
casts theint64
to afloat64
value. Is there a reason for this?jaeger-lib/metrics/prometheus/factory.go
Lines 230 to 232 in 78a0e7f
jaeger-lib/metrics/tally/metrics.go
Lines 49 to 51 in 78a0e7f
jaeger-lib/metrics/go-kit/metrics.go
Lines 49 to 51 in 78a0e7f
Proposal
Update
Gauge
to usefloat64
instead ofint64
injaeger-lib
3.0; alternativelyjaeger-lib
can declare new typesGaugeV2
,FactoryV2
, etc and create an adaptor.The text was updated successfully, but these errors were encountered: