Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support go mod #74

Open
skyrocknroll opened this issue Aug 30, 2019 · 4 comments · Fixed by #75
Open

Please support go mod #74

skyrocknroll opened this issue Aug 30, 2019 · 4 comments · Fixed by #75

Comments

@skyrocknroll
Copy link

skyrocknroll commented Aug 30, 2019

Support Go mod so that downstream projects can migrate to go mod

@skyrocknroll
Copy link
Author

@yurishkuro
Copy link
Member

For the time being, we need to keep Gopkg.toml, so if we add support for go mod, we need to manually keep it in sync w/ Gopkg.toml and add a new build to the Travis matrix.

@sagikazarmark
Copy link
Contributor

Currently this project is not installable on Go 1.13 when a project uses go modules:

	go.uber.org/cadence/client imports
	go.uber.org/cadence/internal tested by
	go.uber.org/cadence/internal.test imports
	github.com/uber/jaeger-client-go/config tested by
	github.com/uber/jaeger-client-go/config.test imports
	github.com/uber/jaeger-lib/metrics/testutils: module github.com/uber/jaeger-lib@latest (v2.0.0+incompatible) found, but does not contain package github.com/uber/jaeger-lib/metrics/testutils

Actually, the root cause is github.com/uber/jaeger-client-go not using go modules. Working on the syntax that uses an earlier version that still works.

@sagikazarmark
Copy link
Contributor

Turns out upgrading the transitive dependency is sufficient:

github.com/uber/jaeger-client-go v2.17.0+incompatible // indirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants